Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 26719003: Fix cross-frame horizontal scrolling on the uber page. (Closed)

Created:
7 years, 2 months ago by Dan Beam
Modified:
7 years, 2 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Fix cross-frame horizontal scrolling on the uber page. Documents in standards mode should now refer to document.documentElement.scroll{Left,Top}. document.body.scroll{Left,Top} is deprecated. R=arv@chromium.org BUG=305745 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/uber/uber_utils.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
7 years, 2 months ago (2013-10-09 18:57:34 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 2 months ago (2013-10-09 18:59:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/26719003/1
7 years, 2 months ago (2013-10-09 19:04:07 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 23:51:10 UTC) #4
Message was sent while issue was closed.
Change committed as 227836

Powered by Google App Engine
This is Rietveld 408576698