Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.h

Issue 2671853002: Rename best icon to best primary icon in Web app related code. (Closed)
Patch Set: Removing java changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.h
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.h b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
index 03f3dac3f35a10f28e4cd857265ed563848602ff..8e6ebf864765dfff8fa6b15bc41ee6897d26bf52 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.h
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
@@ -62,11 +62,11 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
void OnDidGetInstallableData(const InstallableData& installable_data);
// Called with the computed Murmur2 hash for the app icon.
- void OnGotIconMurmur2Hash(const std::string& best_icon_murmur2_hash);
+ void OnGotIconMurmur2Hash(const std::string& best_primary_icon_murmur2_hash);
void OnDataAvailable(const ShortcutInfo& info,
- const std::string& best_icon_murmur2_hash,
- const SkBitmap& best_icon);
+ const std::string& best_primary_icon_murmur2_hash,
+ const SkBitmap& best_primary_icon);
// Called when a page has no Web Manifest or the Web Manifest is not WebAPK
// compatible.
@@ -92,7 +92,7 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
// Downloaded data for |web_manifest_url_|.
ShortcutInfo info_;
- SkBitmap best_icon_;
+ SkBitmap best_primary_icon_;
base::WeakPtrFactory<WebApkUpdateDataFetcher> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698