Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2671853002: Rename best icon to best primary icon in Web app related code. (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index e5f96225074296d8df1ec0f325b08f56ee755f47..e19260aa2dd759600e211a685331085901e9c588 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -44,7 +44,7 @@ std::unique_ptr<ShortcutInfo> CreateShortcutInfo(
if (!manifest.IsEmpty()) {
shortcut_info->UpdateFromManifest(manifest);
shortcut_info->manifest_url = manifest_url;
- shortcut_info->best_icon_url = icon_url;
+ shortcut_info->best_primary_icon_url = icon_url;
shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);
}
return shortcut_info;
@@ -273,9 +273,9 @@ bool AppBannerManagerAndroid::CheckPlatformAndId(const std::string& platform,
const bool correct_platform = (platform == "play");
if (correct_platform && !id.empty())
return true;
- ReportStatus(web_contents(),
- correct_platform ? NO_ID_SPECIFIED
- : PLATFORM_NOT_SUPPORTED_ON_ANDROID);
+ ReportStatus(
+ web_contents(),
+ correct_platform ? NO_ID_SPECIFIED : PLATFORM_NOT_SUPPORTED_ON_ANDROID);
return false;
}
@@ -300,7 +300,6 @@ jint GetHomescreenLanguageOption(JNIEnv* env,
return AppBannerSettingsHelper::GetHomescreenLanguageOption();
}
-
// static
ScopedJavaLocalRef<jobject> GetJavaBannerManagerForWebContents(
JNIEnv* env,
@@ -308,8 +307,8 @@ ScopedJavaLocalRef<jobject> GetJavaBannerManagerForWebContents(
const JavaParamRef<jobject>& java_web_contents) {
AppBannerManagerAndroid* manager = AppBannerManagerAndroid::FromWebContents(
content::WebContents::FromJavaWebContents(java_web_contents));
- return manager? ScopedJavaLocalRef<jobject>(manager->GetJavaBannerManager())
- : ScopedJavaLocalRef<jobject>();
+ return manager ? ScopedJavaLocalRef<jobject>(manager->GetJavaBannerManager())
+ : ScopedJavaLocalRef<jobject>();
}
// static

Powered by Google App Engine
This is Rietveld 408576698