Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

Issue 2671853002: Rename best icon to best primary icon in Web app related code. (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
index d69c5fa0eacf2953e369d597e09516413b36b243..593186c28d61e16b9375513b79c145a41203b3b0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
@@ -52,7 +52,7 @@ public class WebApkUpdateDataFetcherTest extends ChromeTabbedActivityTestBase {
extends CallbackHelper implements WebApkUpdateDataFetcher.Observer {
private boolean mWebApkCompatible;
private String mName;
- private String mBestIconMurmur2Hash;
+ private String mBestPrimaryIconMurmur2Hash;
@Override
public void onWebManifestForInitialUrlNotWebApkCompatible() {
@@ -61,11 +61,12 @@ public class WebApkUpdateDataFetcherTest extends ChromeTabbedActivityTestBase {
}
@Override
- public void onGotManifestData(WebApkInfo fetchedInfo, String bestIconUrl) {
+ public void onGotManifestData(WebApkInfo fetchedInfo, String bestPrimaryIconUrl) {
assertNull(mName);
mWebApkCompatible = true;
mName = fetchedInfo.name();
- mBestIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap().get(bestIconUrl);
+ mBestPrimaryIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap()
+ .get(bestPrimaryIconUrl);
notifyCalled();
}
@@ -77,8 +78,8 @@ public class WebApkUpdateDataFetcherTest extends ChromeTabbedActivityTestBase {
return mName;
}
- public String bestIconMurmur2Hash() {
- return mBestIconMurmur2Hash;
+ public String bestPrimaryIconMurmur2Hash() {
+ return mBestPrimaryIconMurmur2Hash;
}
}
@@ -191,6 +192,6 @@ public class WebApkUpdateDataFetcherTest extends ChromeTabbedActivityTestBase {
mTestServer.getURL(WEB_MANIFEST_WITH_LONG_ICON_MURMUR2_HASH), waiter);
waiter.waitForCallback(0);
- assertEquals(LONG_ICON_MURMUR2_HASH, waiter.bestIconMurmur2Hash());
+ assertEquals(LONG_ICON_MURMUR2_HASH, waiter.bestPrimaryIconMurmur2Hash());
}
}

Powered by Google App Engine
This is Rietveld 408576698