Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3335)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 267183002: Password manager: Implement password generation UI for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_popup_view_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index cddf254bbe0972f3d7a5bb0ff323c16be2940cf0..abc635ce0355283ad962fe37380855b3583832f0 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -292,8 +292,8 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
const autofill::PasswordForm& form) {
// TODO(gcasto): Validate data in PasswordForm.
- // Only implemented for Aura right now.
-#if defined(USE_AURA)
+ // Not yet implemented on other platforms.
+#if defined(USE_AURA) || defined(OS_MACOSX)
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
@@ -307,16 +307,15 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(true /* display_password */);
-#endif // #if defined(USE_AURA)
+#endif // defined(USE_AURA) || defined(OS_MACOSX)
}
void ChromePasswordManagerClient::ShowPasswordEditingPopup(
const gfx::RectF& bounds,
const autofill::PasswordForm& form) {
- // Only implemented for Aura right now.
-#if defined(USE_AURA)
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
-
+ // Not yet implemented on other platforms.
+#if defined(USE_AURA) || defined(OS_MACOSX)
popup_controller_ =
autofill::PasswordGenerationPopupControllerImpl::GetOrCreate(
popup_controller_,
@@ -328,7 +327,7 @@ void ChromePasswordManagerClient::ShowPasswordEditingPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(false /* display_password */);
-#endif // #if defined(USE_AURA)
+#endif // defined(USE_AURA) || defined(OS_MACOSX)
}
void ChromePasswordManagerClient::CommitFillPasswordForm(
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_popup_view_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698