Password manager: Implement password generation UI for Mac.

chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
index 09119f4a976055835435fa7fcd6b94c2a92298b5..a47aa32342dac592c45a91cb821f24af26eaa9fe 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
@@ -10,20 +10,22 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
+#include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"
 
 @class AutofillPopupViewCocoa;
 @class NSWindow;
 
 namespace autofill {
 
-class AutofillPopupController;
+class AutofillPopupViewDelegate;
 
-// Mac implementation for AutofillPopupView interface.
-// Serves as a bridge to the Objective-C class AutofillPopupViewCocoa which
-// actually implements the view.
+// Mac implementation of the AutofillPopupView interface.
+// Serves as a bridge to an instance of the Objective-C class which actually
+// implements the view.
 class AutofillPopupViewBridge : public AutofillPopupView {
  public:
-  explicit AutofillPopupViewBridge(AutofillPopupController* controller);
+  explicit AutofillPopupViewBridge(
+      AutofillPopupViewCocoa* view, AutofillPopupController* controller);

[Ilya Sherman, 2014/05/09 21:51:28]

nit: No longer needs to be explicit.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Please add docs.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: One param per line.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

[Patrick Dubroy, 2014/05/12 14:13:39]

I can't think of any useful documentation to add here.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

 
  private:
   virtual ~AutofillPopupViewBridge();
@@ -34,16 +36,13 @@ class AutofillPopupViewBridge : public AutofillPopupView {
   virtual void InvalidateRow(size_t row) OVERRIDE;
   virtual void UpdateBoundsAndRedrawPopup() OVERRIDE;
 
-  // Set the initial bounds of the popup to show, including the placement
-  // of it.
+  // Set the initial bounds of the popup, including its placement.
   void SetInitialBounds();
 
-  // The controller for this view.
-  AutofillPopupController* controller_;  // Weak reference.
+  // The native Cocoa view.
+  AutofillPopupViewCocoa* view_;  // Weak reference, owned by |window_|.

[Ilya Sherman, 2014/05/09 21:51:28]

|window_| no longer refers to any member of this class.

[Ilya Sherman, 2014/05/09 21:51:28]

Is the |view_| guaranteed to outlive the bridge?  If so, please document that. 
Otherwise, how does this class know whether it is safe to access the variable?

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

[Patrick Dubroy, 2014/05/12 14:13:39]

Fixed.

 
-  // The native Cocoa window and view.
-  NSWindow* window_;  // Weak reference, owns itself.
-  AutofillPopupViewCocoa* view_;  // Weak reference, owned by the |window_|.
+  AutofillPopupController* controller_;  // Weak reference.
 
   DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewBridge);
 };