Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2687)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 267183002: Password manager: Implement password generation UI for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove some dead code, add TODO. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 31329aafa90052d833a1744f837732ed210a56fd..28cfee4d93d5c21ef1aa7660f7f65e5bed8494db 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -272,8 +272,6 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
const autofill::PasswordForm& form) {
// TODO(gcasto): Validate data in PasswordForm.
- // Only implemented for Aura right now.
-#if defined(USE_AURA)
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
@@ -287,14 +285,11 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(true /* display_password */);
-#endif // #if defined(USE_AURA)
}
void ChromePasswordManagerClient::ShowPasswordEditingPopup(
const gfx::RectF& bounds,
const autofill::PasswordForm& form) {
- // Only implemented for Aura right now.
-#if defined(USE_AURA)
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
@@ -308,7 +303,6 @@ void ChromePasswordManagerClient::ShowPasswordEditingPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(false /* display_password */);
-#endif // #if defined(USE_AURA)
}
void ChromePasswordManagerClient::CommitFillPasswordForm(

Powered by Google App Engine
This is Rietveld 408576698