Password manager: Implement password generation UI for Mac.

chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: 2014.  Please fix throughout.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_BRIDGE_H_
+#define CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_BRIDGE_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "chrome/browser/ui/autofill/password_generation_popup_view.h"
+#import "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h"

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Can this #import be tucked into the implementation file?

[Patrick Dubroy, 2014/05/12 14:13:39]

Yep, done.

+
+@class AutofillPopupViewCocoa;

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Did you mean to forward-declare the password generation class?

[Patrick Dubroy, 2014/05/12 14:13:39]

Yeah, done. Though, oddly it seems it's not necessary (?)

[Ilya Sherman, 2014/05/12 21:46:10]

I think it's because you were importing the header previously.

+@class NSWindow;
+
+namespace autofill {
+
+class AutofillPopupController;
+
+// Mac implementation for PasswordGenerationPopupView interface.
+// Serves as a bridge to the Objective-C class PasswordGenerationPopupViewCocoa
+// which actually implements the view.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: I saw that you updated the corresponding comment on the other bridge class.
 Please make the comments for the two classes match.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+class PasswordGenerationPopupViewBridge : public PasswordGenerationPopupView {
+ public:
+  explicit PasswordGenerationPopupViewBridge(
+      PasswordGenerationPopupViewCocoa* view);
+
+ private:
+  virtual ~PasswordGenerationPopupViewBridge();
+
+  // AutofillPopupView implementation.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: "// PasswordGenerationPopupView:" (at least, I assume that's where these
methods are coming from)

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+  virtual void Hide() OVERRIDE;
+  virtual void Show() OVERRIDE;
+  virtual void UpdateBoundsAndRedrawPopup() OVERRIDE;
+  virtual void PasswordSelectionUpdated() OVERRIDE;
+
+  // The native Cocoa view.
+  PasswordGenerationPopupViewCocoa* view_;  // Weak, owned by |window_|.

[Ilya Sherman, 2014/05/09 21:51:28]

Same question here about lifetime and member variable access.

[Patrick Dubroy, 2014/05/12 14:13:39]

Fixed.

+
+  DISALLOW_COPY_AND_ASSIGN(PasswordGenerationPopupViewBridge);
+};
+
+}  // namespace autofill
+
+#endif  // CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_BRIDGE_H_