Password manager: Implement password generation UI for Mac.

chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[Ilya Sherman, 2014/05/09 21:51:28]

Ultra nit: No need for "(c)".  Please change this throughout the CL.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_BASE_VIEW_COCOA_H_
+#define CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_BASE_VIEW_COCOA_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/base_view.h"
+
+namespace autofill {
+class AutofillPopupController;

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Not needed?

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+class AutofillPopupViewDelegate;
+}  // namespace autofill

[Ilya Sherman, 2014/05/09 21:51:28]

nit: No need for the trailing "// namespace" comment when forward-declaring.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+
+@interface AutofillPopupBaseViewCocoa : BaseView {
+ @private
+   __weak autofill::AutofillPopupViewDelegate* delegate_;
+}
+
+- (NSColor*)backgroundColor;
+- (NSColor*)borderColor;
+- (NSColor*)separatorColor;
+- (NSColor*)highlightColor;
+- (NSColor*)nameColor;
+- (NSColor*)warningColor;
+- (NSColor*)subtextColor;

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Alphabetize?

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+
+// Informs the view that its controller has been (or will imminently be)
+// destroyed.
+- (void)controllerDestroyed;

[Ilya Sherman, 2014/05/09 21:51:28]

The base view has no concept of a controller.  Perhaps this should be called
delegateDestroyed?

[Patrick Dubroy, 2014/05/12 14:13:39]

Actually, I don't think we need this at all.

+
+- (id)initWithAutofillPopupViewDelegate:
+    (autofill::AutofillPopupViewDelegate*)delegate frame:(NSRect)frame;

[Ilya Sherman, 2014/05/09 21:51:28]

nit: I'd write this as

- (id)initWithDelegate:(autofill::AutofillPopupViewDelegate*)delegate
                 frame:(NSRect)frame;

(so, shorten the method name, and align on colons)

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+
+  // Draw the popup's background and border.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: De-indent.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+- (void)drawBackgroundAndBorderInRect:(NSRect)dirtyRect;
+
+// Draws a thin separator in the popup UI.
+- (void)drawSeparatorWithBounds:(NSRect)bounds;
+
+// Messages from AutofillPopupViewBridge:
+- (void)updateBoundsAndRedrawPopup;
+- (void)showPopup;
+- (void)hidePopup;
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_BASE_VIEW_COCOA_H_