Password manager: Implement password generation UI for Mac.

chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
-#include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h"
+#include "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h"
 
 #include "base/logging.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
-#import "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"
+#import "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h"
 #include "ui/base/cocoa/window_size_constants.h"
 #include "ui/gfx/rect.h"
 
 namespace autofill {
 
-AutofillPopupViewBridge::AutofillPopupViewBridge(
-    AutofillPopupController* controller)
+PasswordGenerationPopupViewBridge::PasswordGenerationPopupViewBridge(
+    PasswordGenerationPopupController* controller)
     : controller_(controller) {
   window_ =
       [[NSWindow alloc] initWithContentRect:ui::kWindowSizeDeterminedLater
                                   styleMask:NSBorderlessWindowMask
                                     backing:NSBackingStoreBuffered
                                       defer:YES];
   // Telling Cocoa that the window is opaque enables some drawing optimizations.
   [window_ setOpaque:YES];
 
-  view_ = [[[AutofillPopupViewCocoa alloc]
+  view_ = [[[PasswordGenerationPopupViewCocoa alloc]
              initWithController:controller_
                           frame:NSZeroRect] autorelease];
+
   [window_ setContentView:view_];
 }
 
-AutofillPopupViewBridge::~AutofillPopupViewBridge() {
+PasswordGenerationPopupViewBridge::~PasswordGenerationPopupViewBridge() {
   [view_ controllerDestroyed];
 
   // Remove the child window before closing, otherwise it can mess up
   // display ordering.
   [[window_ parentWindow] removeChildWindow:window_];
 
   [window_ close];
 }
 
-void AutofillPopupViewBridge::Hide() {
+void PasswordGenerationPopupViewBridge::Hide() {
   delete this;
 }
 
-void AutofillPopupViewBridge::Show() {
+void PasswordGenerationPopupViewBridge::Show() {
   UpdateBoundsAndRedrawPopup();
   [[controller_->container_view() window] addChildWindow:window_
                                                  ordered:NSWindowAbove];
 }
 
-void AutofillPopupViewBridge::InvalidateRow(size_t row) {
-  NSRect dirty_rect =
-      NSRectFromCGRect(controller_->GetRowBounds(row).ToCGRect());
-  [view_ setNeedsDisplayInRect:dirty_rect];
-}
-
-void AutofillPopupViewBridge::UpdateBoundsAndRedrawPopup() {
+void PasswordGenerationPopupViewBridge::UpdateBoundsAndRedrawPopup() {
   NSRect frame = NSRectFromCGRect(controller_->popup_bounds().ToCGRect());
 
   // Flip coordinates back into Cocoa-land.  The controller's platform-neutral
   // coordinate space places the origin at the top-left of the first screen,
   // whereas Cocoa's coordinate space expects the origin to be at the
   // bottom-left of this same screen.
   NSScreen* screen = [[NSScreen screens] objectAtIndex:0];
   frame.origin.y = NSMaxY([screen frame]) - NSMaxY(frame);
 
   // TODO(isherman): The view should support scrolling if the popup gets too
   // big to fit on the screen.
   [window_ setFrame:frame display:YES];
   [view_ setNeedsDisplay:YES];
 }

[Ilya Sherman, 2014/05/07 00:34:44]

There's a whole bunch of duplicated code in this file.  Are you planning to
share most of it?

[Patrick Dubroy, 2014/05/07 16:48:36]

I've taken a crack at it in the latest patchset. Basically, I've pushed all the
shared functionality into the common view class. I decided against creating a
shared superclass for the bridges, because it feels like there is already enough
inheritance going on amongst all these classes that I didn't want to make it
more confusing. What do you think?

I think the contents of showPopup and hidePopup don't *really* belong in the
view, but if I were to put them in another class, I'd be tempted to put it in a
class that I could use through composition, e.g. AutofillPopupControllerCocoa or
something. Any thoughts?

[Ilya Sherman, 2014/05/08 00:34:32]

I'm fine with either composition or inheritance.  Your current approach seems
reasonable.  Thanks!

 
-AutofillPopupView* AutofillPopupView::Create(
-    AutofillPopupController* controller) {
-  return new AutofillPopupViewBridge(controller);
+void PasswordGenerationPopupViewBridge::PasswordSelectionUpdated() {
+  NOTREACHED() << "Not implemented";
+}
+
+
+PasswordGenerationPopupView* PasswordGenerationPopupView::Create(
+    PasswordGenerationPopupController* controller) {
+  return new PasswordGenerationPopupViewBridge(controller);
 }
 
 }  // namespace autofill