Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2671773007: Add code to locate a plugin within a package (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/plugin/plugin_locator.dart View 1 chunk +86 lines, -0 lines 2 comments Download
A pkg/analysis_server/test/src/plugin/plugin_locator_test.dart View 1 chunk +90 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-05 19:14:20 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2671773007/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart File pkg/analysis_server/lib/src/plugin/plugin_locator.dart (right): https://codereview.chromium.org/2671773007/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart#newcode31 pkg/analysis_server/lib/src/plugin/plugin_locator.dart:31: * directory. Update it?
3 years, 10 months ago (2017-02-05 19:48:07 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 9c9de9e48c334881bd010476c458e327e623a436 (presubmit successful).
3 years, 10 months ago (2017-02-05 19:58:12 UTC) #5
Brian Wilkerson
3 years, 10 months ago (2017-02-05 20:00:22 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2671773007/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/plugin_locator.dart (right):

https://codereview.chromium.org/2671773007/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/plugin_locator.dart:31: * directory.
Done

Powered by Google App Engine
This is Rietveld 408576698