ios/web/public/navigation_item_list.mm - Issue 2671773005: Updated CRWSessionController interface to use NavigationItems.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/public/navigation_item_list.mm

Issue 2671773005: Updated CRWSessionController interface to use NavigationItems. (Closed)

Patch Set: self review Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/web/public/navigation_item_list.h"

	6

	7 namespace web {

	8

	9 NavigationItemList CreateUnscopedNavigationItemList(

	10 const ScopedNavigationItemList& scoped_list) {

	11 NavigationItemList list;
	Eugene But (OOO till 7-30) 2017/02/03 23:33:33 Construct with size? Construct with size? kkhorimoto 2017/02/04 02:45:31 Done. Show quoted text On 2017/02/03 23:33:33, Eugene But wrote: > Construct with size? Done.
	12 for (size_t index = 0; index < scoped_list.size(); ++index)

	13 list.push_back(scoped_list[index].get());
	Eugene But (OOO till 7-30) 2017/02/03 23:33:33 emplace_back ? emplace_back ? kkhorimoto 2017/02/04 02:45:31 Acknowledged. Show quoted text On 2017/02/03 23:33:33, Eugene But wrote: > emplace_back ? Acknowledged.
	14 return list;

	15 }

	16

	17 } // namespace web

OLD	NEW