ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm - Issue 2671743002: Separate state of basic and advanced tab in CBD dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm

Issue 2671743002: Separate state of basic and advanced tab in CBD dialog (Closed)

Patch Set: rebase and fix compilation Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm

index f2deed453e6f2d9bbbb14279900b6128694bb84f..a4a3f94df2d5c0162020340241646416da9f6c14 100644

--- a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm

@@ -234,7 +234,7 @@ TEST_F(ClearBrowsingDataCollectionViewControllerTest,

ASSERT_EQ("en", GetApplicationContext()->GetApplicationLocale());

PrefService* prefs = browser_state_->GetPrefs();

prefs->SetInteger(browsing_data::prefs::kDeleteTimePeriod,

- browsing_data::ALL_TIME);

+ static_cast<int>(browsing_data::TimePeriod::ALL_TIME));

CacheCounter counter(browser_state_.get());

// Test multiple possible types of formatting.

@@ -274,7 +274,7 @@ TEST_F(ClearBrowsingDataCollectionViewControllerTest,

}

PrefService* prefs = browser_state_->GetPrefs();

prefs->SetInteger(browsing_data::prefs::kDeleteTimePeriod,

- browsing_data::LAST_HOUR);

+ static_cast<int>(browsing_data::TimePeriod::LAST_HOUR));

CacheCounter counter(browser_state_.get());

// Test multiple possible types of formatting.