Separate state of basic and advanced tab in CBD dialog

chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences.privacy;
 
 import android.app.Fragment;
 import android.app.FragmentManager;
 import android.content.Context;
 import android.os.Bundle;
@@ skipping 12 matching lines @@
 import org.chromium.chrome.browser.preferences.Preferences;
 
 import java.util.Locale;
 
 /**
  * Fragment with a {@link TabLayout} containing a basic and an advanced version of the CBD dialog.
  */
 public class ClearBrowsingDataTabsFragment extends Fragment {
     public static final int CBD_TAB_COUNT = 2;
 
-    public ClearBrowsingDataTabsFragment() {}
+    public ClearBrowsingDataTabsFragment() {

[msramek, 2017/02/08 10:55:56]

Note that migrating syncable preferences is sometimes difficult; you do the
migration on browser startup when Sync is not running, then Sync kicks in and
overwrites the just migrated preferences with their server values, which are
typically exactly the pre-migration values.

Fortunately, this is not a problem in our case. Since we're just adding new
preferences, the server will have no values for them when the migration first
happens.

It might be worth noting this in a comment.

[dullweber, 2017/02/08 23:03:18]

This code also isn't executed when chrome starts but only when you open the new
dialog for the first time. 

+        PrefServiceBridge.getInstance().migrateBrowsingDataPreferences();

[msramek, 2017/02/08 10:55:56]

Please add a TODO to remove this code in, let's say, three milestones (that
would be M61 or M62, depending on when this is finished).

We do the migration to provide smooth experience for users who will be using
Chromium when this feature launches. We want to make sure that they won't be
surprised by a sudden change in checkbox configuration overnight.

For users who don't use Chrome for several milestones (e.g. update M57->M62)
this is not as important; and would only add code complexity.

[dullweber, 2017/02/08 23:03:18]

Done.

+    }
 
     public static boolean isFeatureEnabled() {

[msramek, 2017/02/08 10:55:55]

Javadocs for public methods plz :)

[dullweber, 2017/02/08 23:03:18]

Done.

         return ChromeFeatureList.isEnabled(ChromeFeatureList.TABS_IN_CBD);
     }
 
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
     }
 
     /*
      * RTL is broken for ViewPager: https://code.google.com/p/android/issues/detail?id=56831
@@ skipping 86 matching lines @@
             PrefServiceBridge.getInstance().setLastSelectedClearBrowsingDataTab(tabIndex);
         }
 
         @Override
         public void onTabUnselected(TabLayout.Tab tab) {}
 
         @Override
         public void onTabReselected(TabLayout.Tab tab) {}
     }
 }