getInstalledRelatedApps: Add browser-side Mojo service (stub).

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 19 matching lines @@
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
 #include "content/browser/frame_host/navigation_request.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/navigator_impl.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "content/browser/frame_host/render_frame_proxy_host.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
+#include "content/browser/installedapp/installed_app_provider_impl_default.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/media/media_interface_proxy.h"
 #include "content/browser/media/session/media_session_service_impl.h"
 #include "content/browser/permissions/permission_service_context.h"
 #include "content/browser/permissions/permission_service_impl.h"
 #include "content/browser/presentation/presentation_service_impl.h"
 #include "content/browser/renderer_host/input/input_router_impl.h"
 #include "content/browser/renderer_host/input/timeout_monitor.h"
 #include "content/browser/renderer_host/media/media_devices_dispatcher_host.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
@@ skipping 2250 matching lines @@
                                               WindowOpenDisposition disposition,
                                               const gfx::Rect& initial_rect,
                                               bool user_gesture) {
   delegate_->ShowCreatedWindow(GetProcess()->GetID(), pending_widget_routing_id,
                                disposition, initial_rect, user_gesture);
 }
 
 void RenderFrameHostImpl::RegisterMojoInterfaces() {
   device::GeolocationServiceContext* geolocation_service_context =
       delegate_ ? delegate_->GetGeolocationServiceContext() : NULL;
+  // The default (no-op) implementation of InstalledAppProvider.
+  // TODO(mgiuca): Implement the "real" one for Android in Java, and do not add
+  // the default one on that platform.
+  GetInterfaceRegistry()->AddInterface(

[clamy, 2017/02/27 14:49:27]

Do we envision the InstalledAppProvider to be used on desktop or will it only be
used on Android? If the later, does it make sense to register an interface
that's doing nothing on desktop? Why not register it just on Android?

[Matt Giuca, 2017/02/27 22:51:15]

We might do it on desktop in the future but no immediate plans (and it isn't
clear what that would mean).

We still want it to work on desktop, and simply return the empty list. I think
that is the best answer to "what native apps are installed?" on a platform that
doesn't have a concept of related native apps. (The web platform team does not
want APIs to be undefined on one platform or another if possible.)

If there was no Mojo service, then we would just fail to get a connection and it
would never resolve the promise. The alternative, I guess, would be to
platform-detect in the Blink code and only try to call the Mojo service on
Android. But I think it's cleaner to have Blink be unaware of the platform, and
have the Chrome-side implementation diverge by registering different Mojo
services.

[clamy, 2017/03/02 13:31:53]

Acknowledged.

+      base::Bind(&InstalledAppProviderImplDefault::Create));
+
   if (geolocation_service_context) {
     // TODO(creis): Bind process ID here so that GeolocationServiceImpl
     // can perform permissions checks once site isolation is complete.
     // crbug.com/426384
     // NOTE: At shutdown, there is no guaranteed ordering between destruction of
     // this object and destruction of any GeolocationServicesImpls created via
     // the below service registry, the reason being that the destruction of the
     // latter is triggered by receiving a message that the pipe was closed from
     // the renderer side. Hence, supply the reference to this object as a weak
     // pointer.
@@ skipping 1172 matching lines @@
   // There is no pending NavigationEntry in these cases, so pass 0 as the
   // pending_nav_entry_id. If the previous handle was a prematurely aborted
   // navigation loaded via LoadDataWithBaseURL, propagate the entry id.
   return NavigationHandleImpl::Create(
       params.url, params.redirects, frame_tree_node_, is_renderer_initiated,
       params.was_within_same_page, base::TimeTicks::Now(),
       entry_id_for_data_nav, false);  // started_from_context_menu
 }
 
 }  // namespace content