Split the Kernel transformations into modular and global ones

Split the Kernel transformations into modular and global ones

Target-specific modular transformations have to be able to cope with
external libraries.  Target-specific global transformations should be
optimizations, and not required for correctness, since a simple linker
may choose not to perform them.

Make mixin resolution modular by making it fail when a mixed-in class
comes from an external library.  (We cannot mix in such a class because
we do not necessarily have all class members.)

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/3057283f0cb329c8caf499c92a69e95e1066d636

[Kevin Millikin (Google), 2017-02-02 09:27:06]

kmillikin@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2017-02-02 11:46:00]

lgtm

https://codereview.chromium.org/2671653003/diff/20001/pkg/kernel/lib/target/f...
File pkg/kernel/lib/target/flutter.dart (right):

https://codereview.chromium.org/2671653003/diff/20001/pkg/kernel/lib/target/f...
pkg/kernel/lib/target/flutter.dart:57: void performGlobalTransformations(Program
program) {
The transformations here are not global, I think.

[Kevin Millikin (Google), 2017-02-02 12:03:48]

Thanks for the review.

https://codereview.chromium.org/2671653003/diff/20001/pkg/kernel/lib/target/f...
File pkg/kernel/lib/target/flutter.dart (right):

https://codereview.chromium.org/2671653003/diff/20001/pkg/kernel/lib/target/f...
pkg/kernel/lib/target/flutter.dart:57: void performGlobalTransformations(Program
program) {
On 2017/02/02 11:46:00, asgerf wrote:
> The transformations here are not global, I think.

They're just not rewritten in this change to skip external libraries.  Some of
them might work, but I didn't verify that.

setup_builtin_library is, unfortunately, global.  It violates the rule that the
dart: libraries cannot depend on the application.

[Kevin Millikin (Google), 2017-02-02 12:08:34]

Description was changed from

==========
Split the Kernel transformations into modular and global ones

Target-specific modular transformations have to be able to cope with
external libraries.  Target-specific global transformations should be
optimizations, and not required for correctness, since a simple linker
may choose not to perform them.

Make mixin resolution modular by making it fail when a mixed-in class
comes from an external library.  (We cannot mix in such a class because
we do not necessarily have all class members.)
==========

to

==========
Split the Kernel transformations into modular and global ones

Target-specific modular transformations have to be able to cope with
external libraries.  Target-specific global transformations should be
optimizations, and not required for correctness, since a simple linker
may choose not to perform them.

Make mixin resolution modular by making it fail when a mixed-in class
comes from an external library.  (We cannot mix in such a class because
we do not necessarily have all class members.)

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3057283f0cb329c8caf499c92a69e95e1066d636
==========

[Kevin Millikin (Google), 2017-02-02 12:08:35]

Committed patchset #2 (id:20001) manually as
3057283f0cb329c8caf499c92a69e95e1066d636 (presubmit successful).