Webapps: Clear AppBannerManagerAndroid::native_app_data_ prior to native app check

chrome/browser/android/banners/app_banner_manager_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager_android.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/android/jni_android.h"
@@ skipping 140 matching lines @@
   // Does not check whether a non-WebAPK web app is installed: this is detected
   // by the content settings check in AppBannerSettingsHelper::ShouldShowBanner
   // (due to the lack of an API to detect what is and isn't on the Android
   // homescreen). This method will still detect the presence of a WebAPK even if
   // Chrome's data is cleared.
   return ShortcutHelper::IsWebApkInstalled(browser_context, start_url,
                                            manifest_url);
 }
 
 void AppBannerManagerAndroid::PerformInstallableCheck() {
+  native_app_data_.Reset();

[dominickn, 2017/02/02 06:53:38]

We should implement this correctly first up rather than in a follow-up.

Let's say we visit a page which triggers a native app banner successfully. We
will carry the native_app_data_ around incorrectly all the way up until this
method is next called.

AppBannerManager is designed such that everything is fetched once per main frame
navigation, and remains valid for the entirety of the length of time the user
spends on the page once they navigate (even if the banner is shown, the data is
still valid, and if we want to allow reshowing the banner in the future we need
to hang on to the data). That means the right place to clean up is in
AppBannerManager::DidFinishNavigation.

You should

1. Add the protected virtual AppBannerManager::ResetData() method, which has:

manifest_ = content::Manifest();
manifest_url_ = GURL();
validated_url_ = GURL();
referrer_.erase();

2. Remove the last two lines above from Stop()

3. Call ResetData() in AppBannerManager::DidFinishNavigation()

4. Override ResetData() in AppBannerManagerAndroid to add:

native_app_data_.Reset();
native_app_package_ = "";

This guarantees that once we navigate, we are back in an unfetched state until
the next fetch succeeds. We have to do a little more work but we ensure that the
banner manager is internally consistent.

+  native_app_package_ = "";
+
   // Check if the manifest prefers that we show a native app banner. If so, call
   // to Java to verify the details.
   if (manifest_.prefer_related_applications &&
       manifest_.related_applications.size()) {
     for (const auto& application : manifest_.related_applications) {
       std::string platform = base::UTF16ToUTF8(application.platform.string());
       std::string id = base::UTF16ToUTF8(application.id.string());
       if (CanHandleNonWebApp(platform, application.url, id))
         return;
     }
@@ skipping 157 matching lines @@
 }
 
 // static
 void SetTotalEngagementToTrigger(JNIEnv* env,
                                  const JavaParamRef<jclass>& clazz,
                                  jdouble engagement) {
   AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement);
 }
 
 }  // namespace banners