Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: src/mksnapshot.cc

Issue 267163002: Revert "Removed default Isolate." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/log.cc ('k') | src/v8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <errno.h> 5 #include <errno.h>
6 #include <stdio.h> 6 #include <stdio.h>
7 #ifdef COMPRESS_STARTUP_DATA_BZ2 7 #ifdef COMPRESS_STARTUP_DATA_BZ2
8 #include <bzlib.h> 8 #include <bzlib.h>
9 #endif 9 #endif
10 #include <signal.h> 10 #include <signal.h>
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 writer.SetRawFiles(i::FLAG_raw_file, i::FLAG_raw_context_file); 386 writer.SetRawFiles(i::FLAG_raw_file, i::FLAG_raw_context_file);
387 #ifdef COMPRESS_STARTUP_DATA_BZ2 387 #ifdef COMPRESS_STARTUP_DATA_BZ2
388 BZip2Compressor bzip2; 388 BZip2Compressor bzip2;
389 writer.SetCompressor(&bzip2); 389 writer.SetCompressor(&bzip2);
390 #endif 390 #endif
391 writer.WriteSnapshot(snapshot_data, ser, context_data, context_ser); 391 writer.WriteSnapshot(snapshot_data, ser, context_data, context_ser);
392 } 392 }
393 393
394 isolate->Exit(); 394 isolate->Exit();
395 isolate->Dispose(); 395 isolate->Dispose();
396 // TODO(svenpanne) Alas, we can't cleanly dispose V8 here, because 396 V8::Dispose();
397 // Serializer::code_address_map_ is static (a.k.a. a global variable), and
398 // disposing that would involve accessing the Isolate just disposed.
399 // code_address_map_ really has to be an instance variable...
400 // V8::Dispose();
401 return 0; 397 return 0;
402 } 398 }
OLDNEW
« no previous file with comments | « src/log.cc ('k') | src/v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698