Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: components/ukm/ukm_service_unittest.cc

Issue 2671603002: Add network information to UKM (Closed)
Patch Set: fix comments and includes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ukm/ukm_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ukm/ukm_service_unittest.cc
diff --git a/components/ukm/ukm_service_unittest.cc b/components/ukm/ukm_service_unittest.cc
index 9827c8f042d0fdafdfcf60b8b2b8ccf3165c252a..5bf9212b1f81f4150fe2f699de34a079570131ed 100644
--- a/components/ukm/ukm_service_unittest.cc
+++ b/components/ukm/ukm_service_unittest.cc
@@ -4,10 +4,14 @@
#include "components/ukm/ukm_service.h"
+#include <string>
+#include <utility>
+
#include "base/test/test_simple_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/metrics/proto/ukm/report.pb.h"
#include "components/metrics/proto/ukm/source.pb.h"
+#include "components/metrics/test_metrics_provider.h"
#include "components/metrics/test_metrics_service_client.h"
#include "components/prefs/testing_pref_service.h"
#include "components/ukm/persisted_logs_metrics_impl.h"
@@ -122,4 +126,30 @@ TEST_F(UkmServiceTest, SourceSerialization) {
EXPECT_EQ(300, proto_source.first_contentful_paint_msec());
}
+TEST_F(UkmServiceTest, MetricsProviderTest) {
+ UkmService service(&prefs_, &client_);
+
+ metrics::TestMetricsProvider* provider = new metrics::TestMetricsProvider();
+ service.RegisterMetricsProvider(
+ std::unique_ptr<metrics::MetricsProvider>(provider));
+
+ service.Initialize();
+
+ // Providers have not supplied system profile information yet.
+ EXPECT_FALSE(provider->provide_system_profile_metrics_called());
+
+ task_runner_->RunUntilIdle();
+ service.EnableReporting();
+
+ service.RecordSource(base::WrapUnique(new UkmSource()));
+ service.Flush();
+ EXPECT_EQ(GetPersistedLogCount(), 1);
+
+ Report proto_report = GetPersistedReport();
+ EXPECT_EQ(1, proto_report.sources_size());
+
+ // Providers have now supplied system profile information.
+ EXPECT_TRUE(provider->provide_system_profile_metrics_called());
+}
+
} // namespace ukm
« no previous file with comments | « components/ukm/ukm_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698