Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Issue 2671583002: Revert of Simplify the initialization of Git objects in Host. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
index 4c5ebcc8ab8cf8bc083af100f92989cb3f55be9a..b3004514defda81ec9d9a865bd0cddf5e817779e 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
@@ -65,9 +65,6 @@
class WebKitPatch(Host):
- # FIXME: It might make more sense if this class had a Host attribute
- # instead of being a Host subclass.
-
global_options = [
optparse.make_option(
"-v", "--verbose", action="store_true", dest="verbose", default=False,
@@ -115,6 +112,7 @@
command.set_option_parser(option_parser)
(options, args) = command.parse_args(args)
+ self.initialize_scm()
(should_execute, failure_reason) = self._should_execute_command(command)
if not should_execute:

Powered by Google App Engine
This is Rietveld 408576698