MacViews: Implement NSAccessibilityPressAction for Views with clickable roles.

ui/views/widget/native_widget_mac_accessibility_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 21 matching lines @@
 NSString* const kTestStringValue = @"Test string value";
 NSString* const kTestTitle = @"Test textfield";
 
 class FlexibleRoleTestView : public View {
  public:
   explicit FlexibleRoleTestView(ui::AXRole role) : role_(role) {}
   void set_role(ui::AXRole role) { role_ = role; }
 
   // Add a child view and resize to fit the child.
   void FitBoundsToNewChild(View* view) {
-    View::AddChildView(view);
+    AddChildView(view);
     // Fit the parent widget to the size of the child for accurate hit tests.
     SetBoundsRect(view->bounds());
   }
 
+  bool mouse_was_pressed() { return mouse_was_pressed_; }

[tapted, 2017/02/09 02:45:18]

nit: const method

[Patti Lor, 2017/02/09 23:11:23]

Done.

+
   // View:
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
     View::GetAccessibleNodeData(node_data);
     node_data->role = role_;
   }
 
+  bool OnMousePressed(const ui::MouseEvent& event) override {
+    mouse_was_pressed_ = true;
+    return false;
+  }
+
  private:
   ui::AXRole role_;
+  bool mouse_was_pressed_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(FlexibleRoleTestView);
 };
 
 class NativeWidgetMacAccessibilityTest : public test::WidgetTest {
  public:
   NativeWidgetMacAccessibilityTest() {}
 
   void SetUp() override {
     test::WidgetTest::SetUp();
     widget_ = CreateTopLevelPlatformWidget();
     widget_->SetBounds(gfx::Rect(50, 50, 100, 100));
     widget()->Show();
   }
 
   void TearDown() override {
     widget_->CloseNow();
     test::WidgetTest::TearDown();
   }
 
-  id AttributeValueAtMidpoint(NSString* attribute) {
+  id A11yElementAtMidpoint() {
     // Accessibility hit tests come in Cocoa screen coordinates.
     NSPoint midpoint_in_screen_ = gfx::ScreenPointToNSPoint(
         widget_->GetWindowBoundsInScreen().CenterPoint());
-    id hit =
+    return
         [widget_->GetNativeWindow() accessibilityHitTest:midpoint_in_screen_];
-    id value = [hit accessibilityAttributeValue:attribute];
+  }
+
+  id AttributeValueAtMidpoint(NSString* attribute) {
+    id value = [A11yElementAtMidpoint() accessibilityAttributeValue:attribute];

[tapted, 2017/02/09 02:45:18]

nit: just return? (i.e. |value| not required)

[Patti Lor, 2017/02/09 23:11:23]

Done, thanks!

     return value;
   }
 
   Textfield* AddChildTextfield(const gfx::Size& size) {
     Textfield* textfield = new Textfield;
     textfield->SetText(base::SysNSStringToUTF16(kTestStringValue));
     textfield->SetAccessibleName(base::SysNSStringToUTF16(kTestTitle));
     textfield->SetSize(size);
     widget()->GetContentsView()->AddChildView(textfield);
     return textfield;
@@ skipping 212 matching lines @@
                 NSAccessibilityVisibleCharacterRangeAttribute) rangeValue]));
 }
 
 // Test writing accessibility attributes via an accessibility client for normal
 // Views.
 TEST_F(NativeWidgetMacAccessibilityTest, ViewWritableAttributes) {
   FlexibleRoleTestView* view = new FlexibleRoleTestView(ui::AX_ROLE_GROUP);
   view->SetSize(GetWidgetBounds().size());
   widget()->GetContentsView()->AddChildView(view);
 
-  // Get the FlexibleRoleTestView accessibility object.
-  NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
-  id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
+  // Make sure the accessibility object tested is the correct one.
+  id ax_node = A11yElementAtMidpoint();
   EXPECT_TRUE(ax_node);
-
-  // Make sure it's the correct accessibility object.
-  id value = [ax_node accessibilityAttributeValue:NSAccessibilityRoleAttribute];
-  EXPECT_NSEQ(NSAccessibilityGroupRole, value);
+  EXPECT_NSEQ(NSAccessibilityGroupRole,
+              AttributeValueAtMidpoint(NSAccessibilityRoleAttribute));
 
   // Make sure |view| is focusable, then focus/unfocus it.
   view->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   EXPECT_FALSE(view->HasFocus());
   EXPECT_FALSE(
       [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute) boolValue]);
   EXPECT_TRUE([ax_node
       accessibilityIsAttributeSettable:NSAccessibilityFocusedAttribute]);
   [ax_node accessibilitySetValue:[NSNumber numberWithBool:YES]
                     forAttribute:NSAccessibilityFocusedAttribute];
@@ skipping 74 matching lines @@
   [ax_node accessibilitySetValue:base::SysUTF16ToNSString(replacement)
                     forAttribute:NSAccessibilitySelectedTextAttribute];
   EXPECT_NSEQ(new_string,
               AttributeValueAtMidpoint(NSAccessibilityValueAttribute));
   EXPECT_EQ(base::SysNSStringToUTF16(new_string), textfield->text());
   // Make sure the cursor is at the end of the replacement.
   EXPECT_EQ(gfx::Range(front.length() + replacement.length()),
             textfield->GetSelectedRange());
 }
 
+// Test performing a 'click' on Views with clickable roles work.
+TEST_F(NativeWidgetMacAccessibilityTest, PressAction) {
+  FlexibleRoleTestView* view = new FlexibleRoleTestView(ui::AX_ROLE_BUTTON);
+  widget()->GetContentsView()->AddChildView(view);
+  view->SetSize(GetWidgetBounds().size());
+
+  id ax_node = A11yElementAtMidpoint();
+  EXPECT_NSEQ(NSAccessibilityButtonRole,
+              AttributeValueAtMidpoint(NSAccessibilityRoleAttribute));
+
+  EXPECT_TRUE([[ax_node accessibilityActionNames]
+      containsObject:NSAccessibilityPressAction]);
+  [ax_node accessibilityPerformAction:NSAccessibilityPressAction];
+  EXPECT_TRUE(view->mouse_was_pressed());
+}
+
 }  // namespace views