third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 2671553005: DevTools: Fix exception on timeline clear

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2671553005: DevTools: Fix exception on timeline clear (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index a39ba22b83a48f18866c9cca3468e42272c75a07..176f28d4fb413ed2448081f5b0a95f8b7b4e8191 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -626,7 +626,8 @@ Timeline.TimelinePanel = class extends UI.Panel {

_clear() {

this._showLandingPage();

- this._detailsSplitWidget.hideSidebar();

+ if (this._detailsSplitWidget)

+ this._detailsSplitWidget.hideSidebar();

this._sessionGeneration = null;

this._recordingStartTime = 0;

this._reset();

« no previous file with comments | « no previous file | no next file » | no next file with comments »