Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2671553005: DevTools: Fix exception on timeline clear (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 619
620 _toggleRecording() { 620 _toggleRecording() {
621 if (this._state === Timeline.TimelinePanel.State.Idle) 621 if (this._state === Timeline.TimelinePanel.State.Idle)
622 this._startRecording(true); 622 this._startRecording(true);
623 else if (this._state === Timeline.TimelinePanel.State.Recording) 623 else if (this._state === Timeline.TimelinePanel.State.Recording)
624 this._stopRecording(); 624 this._stopRecording();
625 } 625 }
626 626
627 _clear() { 627 _clear() {
628 this._showLandingPage(); 628 this._showLandingPage();
629 this._detailsSplitWidget.hideSidebar(); 629 if (this._detailsSplitWidget)
630 this._detailsSplitWidget.hideSidebar();
630 this._sessionGeneration = null; 631 this._sessionGeneration = null;
631 this._recordingStartTime = 0; 632 this._recordingStartTime = 0;
632 this._reset(); 633 this._reset();
633 } 634 }
634 635
635 _reset() { 636 _reset() {
636 PerfUI.LineLevelProfile.instance().reset(); 637 PerfUI.LineLevelProfile.instance().reset();
637 this._tracingModel.reset(); 638 this._tracingModel.reset();
638 this._model.reset(); 639 this._model.reset();
639 for (let extensionEntry of this._extensionTracingModels) 640 for (let extensionEntry of this._extensionTracingModels)
(...skipping 909 matching lines...) Expand 10 before | Expand all | Expand 10 after
1549 return true; 1550 return true;
1550 case 'timeline.jump-to-next-frame': 1551 case 'timeline.jump-to-next-frame':
1551 panel._jumpToFrame(1); 1552 panel._jumpToFrame(1);
1552 return true; 1553 return true;
1553 } 1554 }
1554 return false; 1555 return false;
1555 } 1556 }
1556 }; 1557 };
1557 1558
1558 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g'); 1559 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698