Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2671533002: complete named params in constructors (Closed)

Created:
3 years, 10 months ago by danrubel
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

complete named params in constructors This add completion suggestions for named parameters in constructors and factories, and prevents other suggestions such as type names, identifiers, etc when they are not appropriate. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f33c3c16769e40130d0ff26ce2524d29f78c4139

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -46 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +44 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 4 chunks +29 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 2 chunks +84 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 10 months ago (2017-02-01 19:27:55 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-01 19:31:37 UTC) #3
danrubel
3 years, 10 months ago (2017-02-01 19:36:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f33c3c16769e40130d0ff26ce2524d29f78c4139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698