Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2671513002: Revert "Encode URIs stored in unlinked summaries to make them Uri.parse() safe." (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Encode URIs stored in unlinked summaries to make them Uri.parse() safe." This reverts commit 023648ec5ea09df897e6dd68f56a8061cdf625b6. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0e670f1df12136e531294828643b930543ce233c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -67 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +4 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-01 18:57:01 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 0e670f1df12136e531294828643b930543ce233c (presubmit successful).
3 years, 10 months ago (2017-02-01 18:58:19 UTC) #3
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-01 19:00:25 UTC) #4
Paul Berry
3 years, 10 months ago (2017-02-01 21:30:39 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698