Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 2671503002: Revert "Delete app jit or aot snapshots as each test is completed to reduce the amount of disk spac… (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 5a54d0b6aaf7a1ecaa4d89063a81841ecff79b71..d0b90f031a47e409f34b527ceaca7a55df16b1c1 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -237,17 +237,9 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
throw "Dart VM cannot run files of type '$type'.";
}
String executable = suite.dartVmBinaryFileName;
- var commands = new List<Command>();
- commands.add(commandBuilder.getVmCommand(executable,
- arguments,
- environmentOverrides,
- needsDFERunner: needsDFERunner));
- if (type == 'application/dart-snapshot') {
- // Delete snapshots as we go to reduce the space required to run the test
- // suite.
- commands.add(commandBuilder.getDeleteCommand(script));
- }
- return commands;
+ return <Command>[
+ commandBuilder.getVmCommand(executable, arguments, environmentOverrides, needsDFERunner: needsDFERunner)
+ ];
}
}
@@ -290,13 +282,10 @@ class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
throw "dart_precompiled cannot run files of type '$type'.";
}
- var commands = new List<Command>();
- commands.add(commandBuilder.getVmCommand(suite.dartPrecompiledBinaryFileName,
- arguments, environmentOverrides));
- // Delete snapshots (dylibs or blobs) as we go to reduce the space required
- // to run the test suite.
- commands.add(commandBuilder.getDeleteCommand(script));
- return commands;
+ return <Command>[
+ commandBuilder.getVmCommand(suite.dartPrecompiledBinaryFileName,
+ arguments, environmentOverrides)
+ ];
}
}
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698