Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2671503002: Revert "Delete app jit or aot snapshots as each test is completed to reduce the amount of disk spac… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration; 10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration;
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 String tempDir, 602 String tempDir,
603 CommandBuilder commandBuilder, 603 CommandBuilder commandBuilder,
604 List arguments, 604 List arguments,
605 Map<String, String> environmentOverrides) { 605 Map<String, String> environmentOverrides) {
606 var commands = new List<Command>(); 606 var commands = new List<Command>();
607 commands.add(this.computeCompilationCommand(tempDir, buildDir, CommandBuilde r.instance, 607 commands.add(this.computeCompilationCommand(tempDir, buildDir, CommandBuilde r.instance,
608 arguments, environmentOverrides)); 608 arguments, environmentOverrides));
609 if (!useBlobs) { 609 if (!useBlobs) {
610 commands.add(this.computeAssembleCommand(tempDir, buildDir, CommandBuilder .instance, 610 commands.add(this.computeAssembleCommand(tempDir, buildDir, CommandBuilder .instance,
611 arguments, environmentOverrides)); 611 arguments, environmentOverrides));
612 // This step reduces the amount of space needed to run the precompilation 612 commands.add(this.computeRemoveAssemblyCommand(tempDir, buildDir,
613 // tests by 60%. 613 CommandBuilder.instance, arguments, environmentOverrides));
614 commands.add(commandBuilder.getDeleteCommand("$tempDir/out.S"));
615 } 614 }
616 return new CommandArtifact(commands, '$tempDir', 'application/dart-precompil ed'); 615 return new CommandArtifact(commands, '$tempDir', 'application/dart-precompil ed');
617 } 616 }
618 617
619 CompilationCommand computeCompilationCommand( 618 CompilationCommand computeCompilationCommand(
620 String tempDir, 619 String tempDir,
621 String buildDir, 620 String buildDir,
622 CommandBuilder commandBuilder, 621 CommandBuilder commandBuilder,
623 List arguments, 622 List arguments,
624 Map<String, String> environmentOverrides) { 623 Map<String, String> environmentOverrides) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 args.addAll([ 690 args.addAll([
692 '-o', 691 '-o',
693 '$tempDir/out.aotsnapshot', 692 '$tempDir/out.aotsnapshot',
694 '$tempDir/out.S' 693 '$tempDir/out.S'
695 ]); 694 ]);
696 695
697 return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk, 696 return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk,
698 bootstrapDependencies(buildDir), exec, args, environmentOverrides); 697 bootstrapDependencies(buildDir), exec, args, environmentOverrides);
699 } 698 }
700 699
700 // This step reduces the amount of space needed to run the precompilation
701 // tests by 60%.
702 CompilationCommand computeRemoveAssemblyCommand(
703 String tempDir,
704 String buildDir,
705 CommandBuilder commandBuilder,
706 List arguments,
707 Map<String, String> environmentOverrides) {
708 var exec = 'rm';
709 var args = ['$tempDir/out.S'];
710
711 return commandBuilder.getCompilationCommand(
712 'remove_assembly',
713 tempDir,
714 !useSdk,
715 bootstrapDependencies(buildDir),
716 exec,
717 args,
718 environmentOverrides);
719 }
720
701 List<String> filterVmOptions(List<String> vmOptions) { 721 List<String> filterVmOptions(List<String> vmOptions) {
702 var filtered = new List.from(vmOptions); 722 var filtered = new List.from(vmOptions);
703 filtered.removeWhere( 723 filtered.removeWhere(
704 (option) => option.startsWith("--optimization-counter-threshold")); 724 (option) => option.startsWith("--optimization-counter-threshold"));
705 filtered.removeWhere( 725 filtered.removeWhere(
706 (option) => option.startsWith("--optimization_counter_threshold")); 726 (option) => option.startsWith("--optimization_counter_threshold"));
707 return filtered; 727 return filtered;
708 } 728 }
709 729
710 List<String> computeCompilerArguments( 730 List<String> computeCompilerArguments(
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 RuntimeConfiguration runtimeConfiguration, 914 RuntimeConfiguration runtimeConfiguration,
895 String buildDir, 915 String buildDir,
896 TestInformation info, 916 TestInformation info,
897 List<String> vmOptions, 917 List<String> vmOptions,
898 List<String> sharedOptions, 918 List<String> sharedOptions,
899 List<String> originalArguments, 919 List<String> originalArguments,
900 CommandArtifact artifact) { 920 CommandArtifact artifact) {
901 return <String>[]; 921 return <String>[];
902 } 922 }
903 } 923 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698