Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: ios/chrome/browser/crash_report/crash_keys.cc

Issue 2671383002: Double variations crash key size (Closed)
Patch Set: Remove an expectation based on chunk size Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/crash/core/common/crash_keys_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/crash_report/crash_keys.h" 5 #include "ios/chrome/browser/crash_report/crash_keys.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/debug/crash_logging.h" 9 #include "base/debug/crash_logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/crash/core/common/crash_keys.h" 11 #include "components/crash/core/common/crash_keys.h"
12 12
13 size_t RegisterChromeIOSCrashKeys() { 13 size_t RegisterChromeIOSCrashKeys() {
14 // The following keys may be chunked by the underlying crash logging system, 14 // The following keys may be chunked by the underlying crash logging system,
15 // but ultimately constitute a single key-value pair. 15 // but ultimately constitute a single key-value pair.
16 base::debug::CrashKey fixed_keys[] = { 16 base::debug::CrashKey fixed_keys[] = {
17 {crash_keys::kBug464926CrashKey, crash_keys::kSmallSize}, 17 {crash_keys::kBug464926CrashKey, crash_keys::kSmallSize},
18 {crash_keys::kChannel, crash_keys::kSmallSize}, 18 {crash_keys::kChannel, crash_keys::kSmallSize},
19 {crash_keys::kMetricsClientId, crash_keys::kSmallSize}, 19 {crash_keys::kMetricsClientId, crash_keys::kSmallSize},
20 {crash_keys::kNumVariations, crash_keys::kSmallSize}, 20 {crash_keys::kNumVariations, crash_keys::kSmallSize},
21 {crash_keys::kVariations, crash_keys::kLargeSize}, 21 {crash_keys::kVariations, crash_keys::kHugeSize},
22 {crash_keys::mac::kZombie, crash_keys::kMediumSize}, 22 {crash_keys::mac::kZombie, crash_keys::kMediumSize},
23 {crash_keys::mac::kZombieTrace, crash_keys::kMediumSize}, 23 {crash_keys::mac::kZombieTrace, crash_keys::kMediumSize},
24 }; 24 };
25 25
26 return base::debug::InitCrashKeys(fixed_keys, arraysize(fixed_keys), 26 return base::debug::InitCrashKeys(fixed_keys, arraysize(fixed_keys),
27 crash_keys::kChunkMaxLength); 27 crash_keys::kChunkMaxLength);
28 } 28 }
OLDNEW
« no previous file with comments | « components/crash/core/common/crash_keys_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698