Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: components/crash/core/common/crash_keys.h

Issue 2671383002: Double variations crash key size (Closed)
Patch Set: Remove an expectation based on chunk size Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | components/crash/core/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_ 5 #ifndef COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_
6 #define COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_ 6 #define COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 const size_t kSmallSize = 63; 58 const size_t kSmallSize = 63;
59 59
60 // A medium crash key, which will be chunked on certain platforms but not 60 // A medium crash key, which will be chunked on certain platforms but not
61 // others. Guaranteed to never be more than four chunks. 61 // others. Guaranteed to never be more than four chunks.
62 const size_t kMediumSize = kSmallSize * 4; 62 const size_t kMediumSize = kSmallSize * 4;
63 63
64 // A large crash key, which will be chunked on all platforms. This should be 64 // A large crash key, which will be chunked on all platforms. This should be
65 // used sparingly. 65 // used sparingly.
66 const size_t kLargeSize = kSmallSize * 16; 66 const size_t kLargeSize = kSmallSize * 16;
67 67
68 // A very large crash key, which will be chunked on all platforms. This should
69 // be used very sparingly.
70 const size_t kHugeSize = kLargeSize * 2;
71
68 // Crash Key Name Constants //////////////////////////////////////////////////// 72 // Crash Key Name Constants ////////////////////////////////////////////////////
69 73
70 // The GUID used to identify this client to the crash system. 74 // The GUID used to identify this client to the crash system.
71 #if defined(OS_MACOSX) 75 #if defined(OS_MACOSX)
72 // When using Crashpad, the crash reporting client ID is the responsibility of 76 // When using Crashpad, the crash reporting client ID is the responsibility of
73 // Crashpad. It is not set directly by Chrome. To make the metrics client ID 77 // Crashpad. It is not set directly by Chrome. To make the metrics client ID
74 // available on the server, it's stored in a distinct key. 78 // available on the server, it's stored in a distinct key.
75 extern const char kMetricsClientId[]; 79 extern const char kMetricsClientId[];
76 #elif defined(OS_WIN) 80 #elif defined(OS_WIN)
77 extern const char kMetricsClientId[]; 81 extern const char kMetricsClientId[];
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // deliberate crash. 118 // deliberate crash.
115 extern const char kZombie[]; 119 extern const char kZombie[];
116 extern const char kZombieTrace[]; 120 extern const char kZombieTrace[];
117 121
118 } // namespace mac 122 } // namespace mac
119 #endif 123 #endif
120 124
121 } // namespace crash_keys 125 } // namespace crash_keys
122 126
123 #endif // COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_ 127 #endif // COMPONENTS_CRASH_CORE_COMMON_CRASH_KEYS_H_
OLDNEW
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | components/crash/core/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698