Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 2671383002: Double variations crash key size (Closed)
Patch Set: Remove an expectation based on chunk size Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper(). 104 // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper().
105 base::debug::CrashKey fixed_keys[] = { 105 base::debug::CrashKey fixed_keys[] = {
106 #if defined(OS_MACOSX) || defined(OS_WIN) 106 #if defined(OS_MACOSX) || defined(OS_WIN)
107 { kMetricsClientId, kSmallSize }, 107 { kMetricsClientId, kSmallSize },
108 #else 108 #else
109 { kClientId, kSmallSize }, 109 { kClientId, kSmallSize },
110 #endif 110 #endif
111 { kChannel, kSmallSize }, 111 { kChannel, kSmallSize },
112 { kActiveURL, kLargeSize }, 112 { kActiveURL, kLargeSize },
113 { kNumVariations, kSmallSize }, 113 { kNumVariations, kSmallSize },
114 { kVariations, kLargeSize }, 114 { kVariations, kHugeSize },
115 { kNumExtensionsCount, kSmallSize }, 115 { kNumExtensionsCount, kSmallSize },
116 { kShutdownType, kSmallSize }, 116 { kShutdownType, kSmallSize },
117 { kBrowserUnpinTrace, kMediumSize }, 117 { kBrowserUnpinTrace, kMediumSize },
118 #if !defined(OS_ANDROID) 118 #if !defined(OS_ANDROID)
119 { kGPUVendorID, kSmallSize }, 119 { kGPUVendorID, kSmallSize },
120 { kGPUDeviceID, kSmallSize }, 120 { kGPUDeviceID, kSmallSize },
121 #endif 121 #endif
122 { kGPUDriverVersion, kSmallSize }, 122 { kGPUDriverVersion, kSmallSize },
123 { kGPUPixelShaderVersion, kSmallSize }, 123 { kGPUPixelShaderVersion, kSmallSize },
124 { kGPUVertexShaderVersion, kSmallSize }, 124 { kGPUVertexShaderVersion, kSmallSize },
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 } 375 }
376 376
377 ScopedPrinterInfo::~ScopedPrinterInfo() { 377 ScopedPrinterInfo::~ScopedPrinterInfo() {
378 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 378 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
379 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 379 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
380 base::debug::ClearCrashKey(key); 380 base::debug::ClearCrashKey(key);
381 } 381 }
382 } 382 }
383 383
384 } // namespace crash_keys 384 } // namespace crash_keys
OLDNEW
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | components/crash/core/common/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698