Issue 267132: Http Cache: Enable byte-range support by default....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267132: Http Cache: Enable byte-range support by default.... (Closed)

Created:
11 years, 2 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org, Chris Evans

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http Cache: Enable byte-range support by default. The command line parameter to modify the behavior changes from --enable-byte-range-support to --disable-byte-range-support BUG=24989 TEST= current tests

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	chrome/browser/net/chrome_url_request_context.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_process.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_cache.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

Thanks. review under b/2071330 (adding Chris) On 2009/10/16 03:16:29, eroman wrote: > lgtm. > > ...

11 years, 2 months ago (2009-10-16 17:52:10 UTC) #3

cevans

11 years, 2 months ago (2009-10-16 18:07:17 UTC) #4

Submit at will :) I'll take care of a review subsequently.

On Fri, Oct 16, 2009 at 10:52 AM, <rvargas@chromium.org> wrote:

> Thanks.
>
> review under b/2071330 (adding Chris)
>
> On 2009/10/16 03:16:29, eroman wrote:
>
>> lgtm.
>>
>
>  (does this need any security review?)
>>
>
>
>
> http://codereview.chromium.org/267132
>

Expand Messages | Collapse Messages