Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 267130: Remove flaky expectations for accessibility tests. They were put in out of laziness by yours truly. (Closed)

Created:
11 years, 2 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove flaky expectations for accessibility tests. They were put in out of laziness by yours truly. TBR=ojan BUG=10322 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 2 months ago (2009-10-15 22:57:27 UTC) #1
ojan
11 years, 2 months ago (2009-10-15 22:59:14 UTC) #2
LGTM!

On Thu, Oct 15, 2009 at 3:57 PM, <dglazkov@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Remove flaky expectations for accessibility tests. They were put in out of
> laziness by yours truly.
>
> TBR=ojan
> BUG=10322
> TEST=none
>
> Please review this at http://codereview.chromium.org/267130
>
> Affected files:
>  M webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> diff --git a/webkit/tools/layout_tests/test_expectations.txt
> b/webkit/tools/layout_tests/test_expectations.txt
> index
>
9fd56b2aaee75770d880082f3ea20d1d3b500464..e1519ca2a3e7d39fede61716930073ce3db0da6d
> 100644
> --- a/webkit/tools/layout_tests/test_expectations.txt
> +++ b/webkit/tools/layout_tests/test_expectations.txt
> @@ -1205,8 +1205,6 @@ BUG13809 WIN LINUX :
> LayoutTests/fast/canvas/canvas-empty-image-pattern.html = F
>  //
> ----------------------------------------------------------------------------
>
>  // Need to finish implementing window.accessibilityController for these to
> work.
> -BUG10322 : LayoutTests/accessibility = FAIL PASS
> -BUG10322 : LayoutTests/accessibility/non-native-image-crash.html = PASS
>  BUG10322 : LayoutTests/accessibility/aria-link-supports-press.html = FAIL
>  BUG10322 : LayoutTests/accessibility/aria-readonly.html = FAIL
>  BUG10322 : LayoutTests/accessibility/aria-tables.html = FAIL
>
>
>

Powered by Google App Engine
This is Rietveld 408576698