Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2671233003: NQE: Always read prefs in cronet (Closed)
Patch Set: ps Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 1f2887f41f798cbe5bed62b2df6bbf612aac2de4..5023068fb8b20a3cc516f9837d8e67308be6bf30 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -22,6 +22,7 @@ import org.chromium.base.PathUtils;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.MetricsUtils.HistogramDelta;
import org.chromium.net.MetricsTestUtil.TestExecutor;
import org.chromium.net.TestUrlRequestCallback.ResponseStep;
import org.chromium.net.impl.CronetEngineBase;
@@ -323,6 +324,12 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
testFramework.mCronetEngine.addRttListener(rttListener);
testFramework.mCronetEngine.addThroughputListener(throughputListener);
+ HistogramDelta writeCountHistogram = new HistogramDelta("NQE.Prefs.WriteCount", 1);
+ assertEquals(0, writeCountHistogram.getDelta()); // Sanity check.
+
+ HistogramDelta readCountHistogram = new HistogramDelta("NQE.Prefs.ReadCount", 1);
+ assertEquals(0, readCountHistogram.getDelta()); // Sanity check.
+
TestUrlRequestCallback callback = new TestUrlRequestCallback();
UrlRequest.Builder builder = testFramework.mCronetEngine.newUrlRequestBuilder(
mUrl, callback, callback.getExecutor());
@@ -336,6 +343,9 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
waitForThroughput.block();
assertTrue(throughputListener.throughputObservationCount() > 0);
+ // Prefs must be read at startup.
+ assertTrue(readCountHistogram.getDelta() > 0);
+
// Check RTT observation count after throughput observation has been received. This ensures
// that executor has finished posting the RTT observation to the RTT listeners.
assertTrue(rttListener.rttObservationCount() > 0);
@@ -367,7 +377,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
// Verify that the cached estimates were written to the prefs.
while (true) {
Log.i(TAG, "Still waiting for pref file update.....");
- Thread.sleep(10000);
+ Thread.sleep(12000);
try {
if (fileContainsString("local_prefs.json", "network_qualities")) {
break;
@@ -380,6 +390,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
assertTrue(fileContainsString("local_prefs.json", "network_qualities"));
testFramework.mCronetEngine.shutdown();
+ assertTrue(writeCountHistogram.getDelta() > 0);
}
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698