Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/bootstrapper.cc

Issue 2671233002: [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (Closed)
Patch Set: alphabetize JSTests.json Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | src/builtins/builtins-typedarray.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index b95cc1ad79365a6eefcd231204e682a621e9bcc4..fa856bcdb06a1cca0a807f21eaa005ea04f49857 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2483,6 +2483,10 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
values->shared()->set_builtin_function_id(kTypedArrayValues);
JSObject::AddProperty(prototype, factory->iterator_symbol(), values,
DONT_ENUM);
+
+ // TODO(caitp): alphasort accessors/methods
+ SimpleInstallFunction(prototype, factory->copyWithin_string(),
+ Builtins::kTypedArrayPrototypeCopyWithin, 2, false);
Benedikt Meurer 2017/02/06 03:54:33 Just use the SimpleInstallFunction which takes a C
caitp 2017/02/06 14:21:13 Done.
}
{ // -- T y p e d A r r a y s
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | src/builtins/builtins-typedarray.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698