src/inspector/v8-debugger-agent-impl.h - Issue 2671193002: [inspector] restore provisional breakpoints smarter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2671193002: [inspector] restore provisional breakpoints smarter (Closed)

Patch Set: removed flaky breakpointId from test results Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-debugger-agent-impl.h

diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h

index d5b174a76c8a546e0a0f2c8d901fec613bd31e29..981a97853606a600255ac329822aca7bfefda91c 100644

--- a/src/inspector/v8-debugger-agent-impl.h

+++ b/src/inspector/v8-debugger-agent-impl.h

@@ -157,7 +157,8 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {

void setPauseOnExceptionsImpl(int);

std::unique_ptr<protocol::Debugger::Location> resolveBreakpoint(

- const String16& breakpointId, const ScriptBreakpoint&, BreakpointSource);

+ const String16& breakpointId, const ScriptBreakpoint&, BreakpointSource,

+ const String16& sourceLineHint);

void removeBreakpointImpl(const String16& breakpointId);

void clearBreakDetails();