Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/inspector/v8-debugger-script.h

Issue 2671193002: [inspector] restore provisional breakpoints smarter (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-script.h
diff --git a/src/inspector/v8-debugger-script.h b/src/inspector/v8-debugger-script.h
index bb869899f25120d13a8d5351348740a0ed825701..cd6fc329fbd887c09f028f75f247ce79cdfc56e3 100644
--- a/src/inspector/v8-debugger-script.h
+++ b/src/inspector/v8-debugger-script.h
@@ -59,8 +59,8 @@ class V8DebuggerScript {
bool hasSourceURL() const { return !m_sourceURL.isEmpty(); }
const String16& sourceURL() const;
virtual const String16& sourceMappingURL() const = 0;
- virtual String16 source(v8::Isolate*) const { return m_source; }
- const String16& hash(v8::Isolate*) const;
+ const String16& source() const { return m_source; }
+ const String16& hash() const;
int startLine() const { return m_startLine; }
int startColumn() const { return m_startColumn; }
int endLine() const { return m_endLine; }
@@ -71,8 +71,9 @@ class V8DebuggerScript {
void setSourceURL(const String16&);
virtual void setSourceMappingURL(const String16&) = 0;
- virtual void setSource(v8::Local<v8::String> source) {
- m_source = toProtocolString(source);
+ void setSource(const String16& source) {
+ m_source = source;
+ m_hash = String16();
}
virtual bool getPossibleBreakpoints(
@@ -81,6 +82,10 @@ class V8DebuggerScript {
std::vector<v8::debug::Location>* locations) = 0;
virtual void resetBlackboxedStateCache() = 0;
+ static const int kNoOffset = -1;
+ virtual int offset(int lineNumber, int columnNumber) const = 0;
+ virtual v8::debug::Location location(int offset) const = 0;
+
protected:
V8DebuggerScript(v8::Isolate*, String16 id, String16 url);
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698