src/debug/debug-interface.h - Issue 2671193002: [inspector] restore provisional breakpoints smarter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-interface.h

Issue 2671193002: [inspector] restore provisional breakpoints smarter (Closed)

Patch Set: offset based approach Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-interface.h

diff --git a/src/debug/debug-interface.h b/src/debug/debug-interface.h

index be8ed902d505503a288701b71c2b4281d4aef9a6..f8e900721ae8c4d77d5afde96b6989e75415a476 100644

--- a/src/debug/debug-interface.h

+++ b/src/debug/debug-interface.h

@@ -138,9 +138,8 @@ class V8_EXPORT_PRIVATE Script {

bool GetPossibleBreakpoints(const debug::Location& start,

const debug::Location& end,

std::vector<debug::Location>* locations) const;

- private:

- int GetSourcePosition(const debug::Location& location) const;

+ int Offset(const debug::Location& location) const;

+ v8::debug::Location Position(int offset) const;

};

// Specialization for wasm Scripts.