third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp - Issue 2671173002: Change CSSParserContext to have a Document handle (vs UseCounter).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

Issue 2671173002: Change CSSParserContext to have a Document handle (vs UseCounter). (Closed)

Patch Set: fix todo style Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

index 1fc270d4e419b9acf92ce357155aef2f150c5ff1..76f80cc9e8b7db4310b96202c2b4b7def454ed9f 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

@@ -21,8 +21,8 @@ const CSSValue* CSSPropertyAPIOffsetPosition::parseSingleValue(

range, context->mode(), CSSPropertyParserHelpers::UnitlessQuirk::Forbid);

// Count when we receive a valid position other than 'auto'.

- if (context->isUseCounterRecordingEnabled() && value && value->isValuePair())

- context->useCounter()->count(UseCounter::CSSOffsetInEffect);

+ if (value && value->isValuePair())

+ context->count(UseCounter::CSSOffsetInEffect);

return value;

}