Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2671173002: Change CSSParserContext to have a Document handle (vs UseCounter). (Closed)
Patch Set: fix todo style Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
index b691724690da945917251b0ab454d5d81f332a5a..ed502005d576616f98a37ef741888b1540a603e0 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
@@ -1200,16 +1200,12 @@ static CSSValue* consumeGeneratedImage(CSSParserTokenRange& range,
result = consumeRadialGradient(args, context->mode(), Repeating);
} else if (id == CSSValueWebkitLinearGradient) {
// FIXME: This should send a deprecation message.
- if (context->isUseCounterRecordingEnabled())
- context->useCounter()->count(UseCounter::DeprecatedWebKitLinearGradient);
+ context->count(UseCounter::DeprecatedWebKitLinearGradient);
result = consumeLinearGradient(args, context->mode(), NonRepeating,
CSSPrefixedLinearGradient);
} else if (id == CSSValueWebkitRepeatingLinearGradient) {
// FIXME: This should send a deprecation message.
- if (context->isUseCounterRecordingEnabled()) {
- context->useCounter()->count(
- UseCounter::DeprecatedWebKitRepeatingLinearGradient);
- }
+ context->count(UseCounter::DeprecatedWebKitRepeatingLinearGradient);
result = consumeLinearGradient(args, context->mode(), Repeating,
CSSPrefixedLinearGradient);
} else if (id == CSSValueRepeatingLinearGradient) {
@@ -1220,20 +1216,15 @@ static CSSValue* consumeGeneratedImage(CSSParserTokenRange& range,
CSSLinearGradient);
} else if (id == CSSValueWebkitGradient) {
// FIXME: This should send a deprecation message.
- if (context->isUseCounterRecordingEnabled())
- context->useCounter()->count(UseCounter::DeprecatedWebKitGradient);
+ context->count(UseCounter::DeprecatedWebKitGradient);
result = consumeDeprecatedGradient(args, context->mode());
} else if (id == CSSValueWebkitRadialGradient) {
// FIXME: This should send a deprecation message.
- if (context->isUseCounterRecordingEnabled())
- context->useCounter()->count(UseCounter::DeprecatedWebKitRadialGradient);
+ context->count(UseCounter::DeprecatedWebKitRadialGradient);
result =
consumeDeprecatedRadialGradient(args, context->mode(), NonRepeating);
} else if (id == CSSValueWebkitRepeatingRadialGradient) {
- if (context->isUseCounterRecordingEnabled()) {
- context->useCounter()->count(
- UseCounter::DeprecatedWebKitRepeatingRadialGradient);
- }
+ context->count(UseCounter::DeprecatedWebKitRepeatingRadialGradient);
result = consumeDeprecatedRadialGradient(args, context->mode(), Repeating);
} else if (id == CSSValueWebkitCrossFade) {
result = consumeCrossFade(args, context);

Powered by Google App Engine
This is Rietveld 408576698