Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 2671173002: Change CSSParserContext to have a Document handle (vs UseCounter). (Closed)
Patch Set: fix todo style Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
index 76269e91409c54eac754764bf470ff7ae1e09c42..8a3fb88d0a4efefc7d0368d5c7a7f59594fc2261 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
@@ -156,8 +156,7 @@ ImmutableStylePropertySet* CSSParserImpl::parseInlineStyleDeclaration(
Element* element) {
Document& document = element->document();
CSSParserContext* context = CSSParserContext::create(
- document.elementSheet().contents()->parserContext(),
- UseCounter::getFrom(&document));
+ document.elementSheet().contents()->parserContext(), &document);
CSSParserMode mode = element->isHTMLElement() && !document.inQuirksMode()
? HTMLStandardMode
: HTMLQuirksMode;
@@ -453,7 +452,7 @@ StyleRuleBase* CSSParserImpl::consumeAtRule(CSSParserTokenRange& range,
CSSParserTokenRange prelude = range.makeSubRange(preludeStart, &range.peek());
CSSAtRuleID id = cssAtRuleID(name);
if (id != CSSAtRuleInvalid && m_context->isUseCounterRecordingEnabled())
- countAtRule(m_context->useCounter(), id);
+ countAtRule(m_context, id);
if (range.atEnd() || range.peek().type() == SemicolonToken) {
range.consume();
@@ -701,8 +700,7 @@ StyleRuleKeyframes* CSSParserImpl::consumeKeyframesRule(
if (nameToken.type() == IdentToken) {
name = nameToken.value().toString();
} else if (nameToken.type() == StringToken && webkitPrefixed) {
- if (m_context->isUseCounterRecordingEnabled())
- m_context->useCounter()->count(UseCounter::QuotedKeyframesRule);
+ m_context->count(UseCounter::QuotedKeyframesRule);
name = nameToken.value().toString();
} else {
return nullptr; // Parse error; expected ident token in @keyframes header

Powered by Google App Engine
This is Rietveld 408576698