pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2671113002: fix #28642, handling of top and bottom types in DDC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2671113002: fix #28642, handling of top and bottom types in DDC (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/dev_compiler/test/browser/runtime_tests.js ('K') | « pkg/dev_compiler/test/browser/runtime_tests.js ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart » ('j') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index d94d1a995bafd3dee2710c5e2322ac35d5c314d3..68d8fd043781de47e7957051c8067abbc6152953 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -513,6 +513,9 @@ instanceOfOrNull(obj, type) => JS(

instanceOf(obj, type) => JS(

'',

'''(() => {

+ if ($obj == null) {

+ return $type == $Null || $_isTop($type);

+ }

let result = $strongInstanceOf($obj, $type);

if (result !== null) return result;

let actual = $getReifiedType($obj);