chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc - Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

index f6fe5f40d071f204fa43a17f85bd634aeb8f8208..22fb503479298b74d00af4fc64395aa23057621a 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

@@ -559,8 +559,8 @@ TEST_F(ContentSettingBubbleModelTest, RegisterProtocolHandler) {

TabSpecificContentSettings* content_settings =

TabSpecificContentSettings::FromWebContents(web_contents());

content_settings->set_pending_protocol_handler(

- ProtocolHandler::CreateProtocolHandler("mailto",

- GURL("http://www.toplevel.example/"), base::ASCIIToUTF16("Handler")));

+ ProtocolHandler::CreateProtocolHandler(

+ "mailto", GURL("http://www.toplevel.example/")));

ContentSettingRPHBubbleModel content_setting_bubble_model(

NULL, web_contents(), profile(), NULL,

@@ -613,8 +613,7 @@ TEST_F(ContentSettingBubbleModelTest, RPHAllow) {

TabSpecificContentSettings* content_settings =

TabSpecificContentSettings::FromWebContents(web_contents());

ProtocolHandler test_handler = ProtocolHandler::CreateProtocolHandler(

- "mailto", GURL("http://www.toplevel.example/"),

- base::ASCIIToUTF16("Handler"));

+ "mailto", GURL("http://www.toplevel.example/"));

content_settings->set_pending_protocol_handler(test_handler);

ContentSettingRPHBubbleModel content_setting_bubble_model(

@@ -633,7 +632,6 @@ TEST_F(ContentSettingBubbleModelTest, RPHAllow) {

{

ProtocolHandler handler = registry.GetHandlerFor("mailto");

ASSERT_FALSE(handler.IsEmpty());

- EXPECT_EQ(base::ASCIIToUTF16("Handler"), handler.title());

EXPECT_EQ(CONTENT_SETTING_ALLOW,

content_settings->pending_protocol_handler_setting());

}

@@ -662,7 +660,6 @@ TEST_F(ContentSettingBubbleModelTest, RPHAllow) {

{

ProtocolHandler handler = registry.GetHandlerFor("mailto");

ASSERT_FALSE(handler.IsEmpty());

- EXPECT_EQ(base::ASCIIToUTF16("Handler"), handler.title());

EXPECT_EQ(CONTENT_SETTING_ALLOW,

content_settings->pending_protocol_handler_setting());

EXPECT_FALSE(registry.IsIgnored(test_handler));