Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/resources/options/handler_options_list.js

Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/handler_options_list.js
diff --git a/chrome/browser/resources/options/handler_options_list.js b/chrome/browser/resources/options/handler_options_list.js
index fef1740de8bcb76ef3f99023f6faadd444090218..12129a89a2558610258ed49cc2162e9e3abf4170 100644
--- a/chrome/browser/resources/options/handler_options_list.js
+++ b/chrome/browser/resources/options/handler_options_list.js
@@ -13,7 +13,7 @@ cr.define('options', function() {
* Creates a new ignored protocol / content handler list item.
*
* Accepts values in the form
- * ['mailto', 'http://www.thesite.com/%s', 'The title of the protocol'],
+ * ['mailto', 'http://www.thesite.com/%s', 'www.thesite.com'],
* @param {Object} entry A dictionary describing the handlers for a given
* protocol.
* @constructor
@@ -40,12 +40,12 @@ cr.define('options', function() {
protocolElement.className = 'handlers-type-column';
this.contentElement_.appendChild(protocolElement);
- // Site title.
- var titleElement = document.createElement('div');
- titleElement.textContent = this.dataItem[2];
- titleElement.className = 'handlers-site-column';
- titleElement.title = this.dataItem[1];
- this.contentElement_.appendChild(titleElement);
+ // Host name.
+ var hostElement = document.createElement('div');
+ hostElement.textContent = this.dataItem[2];
+ hostElement.className = 'handlers-site-column';
+ hostElement.title = this.dataItem[1];
+ this.contentElement_.appendChild(hostElement);
},
};
@@ -90,7 +90,7 @@ cr.define('options', function() {
* Accepts values in the form
* { protocol: 'mailto',
* handlers: [
- * ['mailto', 'http://www.thesite.com/%s', 'The title of the protocol'],
+ * ['mailto', 'http://www.thesite.com/%s', 'www.thesite.com'],
* ...,
* ],
* }
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698