chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc - Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

index 11c206ffccbcbeb5b815698e75b14bc9f8bb7881..e12b0a2a015859d1ea055153acfd9bd06f03760f 100644

--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

@@ -46,23 +46,28 @@ base::string16

RegisterProtocolHandlerPermissionRequest::GetMessageText() const {

ProtocolHandler old_handler = registry_->GetHandlerFor(handler_.protocol());

return old_handler.IsEmpty() ?

- l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,

- handler_.title(), base::UTF8ToUTF16(handler_.url().host()),

+ l10n_util::GetStringFUTF16(

+ IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,

+ base::UTF8ToUTF16(handler_.url().host()),

GetProtocolName(handler_)) :

- l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_REPLACE,

- handler_.title(), base::UTF8ToUTF16(handler_.url().host()),

- GetProtocolName(handler_), old_handler.title());

+ l10n_util::GetStringFUTF16(

+ IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_REPLACE,

+ base::UTF8ToUTF16(handler_.url().host()),

+ GetProtocolName(handler_),

+ base::UTF8ToUTF16(old_handler.url().host()));

}

base::string16

RegisterProtocolHandlerPermissionRequest::GetMessageTextFragment() const {

ProtocolHandler old_handler = registry_->GetHandlerFor(handler_.protocol());

return old_handler.IsEmpty() ?

- l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_FRAGMENT,

+ l10n_util::GetStringFUTF16(

+ IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_FRAGMENT,

GetProtocolName(handler_)) :

l10n_util::GetStringFUTF16(

IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_REPLACE_FRAGMENT,

- GetProtocolName(handler_), old_handler.title());

+ GetProtocolName(handler_),

+ base::UTF8ToUTF16(old_handler.url().host()));

}

bool RegisterProtocolHandlerPermissionRequest::HasUserGesture() const {