Ignore title parameter for navigator.registerProtocolHandler.

chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/common/url_constants.h"
@@ skipping 54 matching lines @@
 
 RegisterProtocolHandlerInfoBarDelegate*
     RegisterProtocolHandlerInfoBarDelegate::
         AsRegisterProtocolHandlerInfoBarDelegate() {
   return this;
 }
 
 base::string16 RegisterProtocolHandlerInfoBarDelegate::GetMessageText() const {
   ProtocolHandler old_handler = registry_->GetHandlerFor(handler_.protocol());
   return old_handler.IsEmpty() ?
-      l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,
-          handler_.title(), base::UTF8ToUTF16(handler_.url().host()),

[jochen (gone - plz use gerrit), 2014/05/06 18:38:30]

is title() used anywhere else? Otherwise, you should rip it out entirely

[meacer, 2014/05/06 18:46:50]

I was actually looking at it now: The content settings page uses the title
instead of the url under the "Site" column. mailto and webcal are initiated as
"Google.com Mail" and "Google Calendar" on Chrome OS. Of course nothing prevents
another site from using the same names.

+      l10n_util::GetStringFUTF16(
+          IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,
+          base::UTF8ToUTF16(handler_.url().host()),
           GetProtocolName(handler_)) :
-      l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_REPLACE,
-          handler_.title(), base::UTF8ToUTF16(handler_.url().host()),
+      l10n_util::GetStringFUTF16(
+          IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM_REPLACE,
+          base::UTF8ToUTF16(handler_.url().host()),
           GetProtocolName(handler_), old_handler.title());
 }
 
 base::string16 RegisterProtocolHandlerInfoBarDelegate::GetButtonLabel(
     InfoBarButton button) const {
   return (button == BUTTON_OK) ?
       l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_ACCEPT,
                                  handler_.title()) :
       l10n_util::GetStringUTF16(IDS_REGISTER_PROTOCOL_HANDLER_DENY);
 }
@@ skipping 35 matching lines @@
 }
 
 base::string16 RegisterProtocolHandlerInfoBarDelegate::GetProtocolName(
     const ProtocolHandler& handler) const {
   if (handler.protocol() == "mailto")
     return l10n_util::GetStringUTF16(IDS_REGISTER_PROTOCOL_HANDLER_MAILTO_NAME);
   if (handler.protocol() == "webcal")
     return l10n_util::GetStringUTF16(IDS_REGISTER_PROTOCOL_HANDLER_WEBCAL_NAME);
   return base::UTF8ToUTF16(handler.protocol());
 }