Better code to determine the framework and helper app paths

chrome/common/chrome_paths_mac.mm

Index: chrome/common/chrome_paths_mac.mm
===================================================================
--- chrome/common/chrome_paths_mac.mm	(revision 28987)
+++ chrome/common/chrome_paths_mac.mm	(working copy)
@@ -67,34 +67,18 @@
 }
 
 FilePath GetVersionedDirectory() {
-  static FilePath path;
+  // Start out with the path to the running .app.
+  NSBundle* app_bundle = [NSBundle mainBundle];

[TVL, 2009/10/14 21:09:15]

since the concern in here was threading,
http://developer.apple.com/mac/library/documentation/Cocoa/Conceptual/Multith...
says NSBundle isn't really thread safe...

[Mark Mentovai, 2009/10/14 21:26:46]

TVL wrote:
Good point.  If we care about this, we should fix base/base_paths_mac.mm too,
which implements FILE_EXE and FILE_MODULE in terms of [[NSBundle mainBundle]
executablePath].

I'm not positive that there's a fantastic way to fix this.  I guess we could use
_NSGetExecutablePath, but we'd need to absolutize it ourselves.

I'll file a p1 bug.

+  FilePath path = FilePath([[app_bundle bundlePath] fileSystemRepresentation]);
 
-  if (path.empty()) {
-    // Start out with the path to the running .app.
-    NSBundle* app_bundle = [NSBundle mainBundle];
-    path = FilePath([[app_bundle bundlePath] fileSystemRepresentation]);
-
-    if (mac_util::IsBackgroundOnlyProcess()) {
-      // path identifies the helper .app in the browser .app's versioned
-      // directory.  Go up one level to get to the browser .app's versioned
-      // directory.
-      path = path.DirName();
-    } else {
-      // path identifies the browser .app.  Go into its versioned directory.
-      // TODO(mark): Here, |version| comes from the outer .app bundle's
-      // Info.plist.  In the event of an incomplete update, it may be possible
-      // for this value to be incorrect.  Consider the case where the updater
-      // is able to update one, but not both, of the executable and the
-      // Info.plist.  The executable may load one version of the framework,
-      // and the Info.plist may refer to another version.  Ideally, the
-      // version would be available in a compile-time constant, or there would
-      // be a better way to detect the loaded framework version at runtime.
-      NSString* version =
-          [app_bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
-      path = path.Append("Contents").
-                  Append("Versions").
-                  Append([version fileSystemRepresentation]);
-    }
+  if (mac_util::IsBackgroundOnlyProcess()) {
+    // path identifies the helper .app in the browser .app's versioned
+    // directory.  Go up one level to get to the browser .app's versioned
+    // directory.
+    path = path.DirName();
+  } else {
+    // path identifies the browser .app.  Go into its versioned directory.
+    path = path.Append("Contents").Append("Versions").Append(kChromeVersion);
   }
 
   return path;