Android: Fire the appinstalled event on WebAPK installation.

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 
 #include <utility>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 334 matching lines @@
   // Prevent the infobar from disappearing, because the infobar will show
   // "Adding" during the installation process.
   return false;
 }
 
 bool AppBannerInfoBarDelegateAndroid::TriggeredFromBanner() const {
   return !is_webapk_ || webapk_install_source_ == webapk::INSTALL_SOURCE_BANNER;
 }
 
 void AppBannerInfoBarDelegateAndroid::SendBannerAccepted() {
-  if (weak_manager_ && TriggeredFromBanner()) {
+  if (!weak_manager_)
+    return;
+
+  if (TriggeredFromBanner())
     weak_manager_->SendBannerAccepted(event_request_id_);
-    // TODO(mgiuca): Send the appinstalled event for WebAPKs (but just removing
-    // this check won't be sufficient).
-    if (!is_webapk_)
-      weak_manager_->OnInstall();
-  }
+
+  // Send the appinstalled event in all cases (whether triggered from a banner

[dominickn, 2017/04/24 00:56:30]

This comment seems superfluous. What's more important is noting that the
appinstalled event is being fired when the user initiates an install, not when
the install finished. For non-WebAPKs, that's fine because install is trivial.
But WebAPKs can take O(seconds) to install so it's not as accurate as it could
be (maybe TODO to fix that).

[Matt Giuca, 2017/04/24 01:42:13]

Done.

I don't think big-oh works like that...

+  // or not).
+  weak_manager_->OnInstall();
 }
 
 void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished(
     WebApkInstallResult result,
     bool relax_updates,
     const std::string& webapk_package_name) {
   if (result != WebApkInstallResult::SUCCESS) {
     OnWebApkInstallFailed(result);
     return;
   }
@@ skipping 92 matching lines @@
 
   TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
   return true;
 }
 
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners