Remove base's ALIGNOF/ALIGNAS in favor of alignof/alignas.

media/base/audio_parameters.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_AUDIO_PARAMETERS_H_
 #define MEDIA_BASE_AUDIO_PARAMETERS_H_
 
 #include <stdint.h>
 #include <string>
 
@@ skipping 14 matching lines @@
 // instead of in Audio{Input,Output}Buffer to be able to calculate size like so.
 // Use a macro for the alignment value that's the same as
 // AudioBus::kChannelAlignment, since MSVC doesn't accept the latter to be used.
 #if defined(OS_WIN)
 #pragma warning(push)
 #pragma warning(disable : 4324)  // Disable warning for added padding.
 #endif
 #define PARAMETERS_ALIGNMENT 16
 static_assert(AudioBus::kChannelAlignment == PARAMETERS_ALIGNMENT,
               "Audio buffer parameters struct alignment not same as AudioBus");
-struct MEDIA_EXPORT ALIGNAS(PARAMETERS_ALIGNMENT) AudioInputBufferParameters {
+struct alignas(PARAMETERS_ALIGNMENT) AudioInputBufferParameters {

[liberato (no reviews please), 2017/02/14 20:02:17]

MEDIA_EXPORT is missing, here and @42.

[dcheng, 2017/02/14 20:06:53]

The export aren't needed (see the green build), since these are just PODs and
the entire definition is in the header.

This probably got lost in the thread, but it's problematic to mix
__attribute__(...) syntax with alignas(...). Since we don't actually need to
export these sybols, we can sidestep it by removing the EXPORT macros.

If this is needed at some point in the future, we'll probably switch the export
macros over to using C++11 attribute syntax, which will work with alignas.

   double volume;
   uint32_t size;
   uint32_t hardware_delay_bytes;
   uint32_t id;
   bool key_pressed;
 };
-struct MEDIA_EXPORT ALIGNAS(PARAMETERS_ALIGNMENT) AudioOutputBufferParameters {
+struct alignas(PARAMETERS_ALIGNMENT) AudioOutputBufferParameters {
   uint32_t frames_skipped;
   int64_t delay;
   int64_t delay_timestamp;
 };
 #undef PARAMETERS_ALIGNMENT
 #if defined(OS_WIN)
 #pragma warning(pop)
 #endif
 
 static_assert(sizeof(AudioInputBufferParameters) %
@@ skipping 177 matching lines @@
   if (a.sample_rate() != b.sample_rate())
     return a.sample_rate() < b.sample_rate();
   if (a.bits_per_sample() != b.bits_per_sample())
     return a.bits_per_sample() < b.bits_per_sample();
   return a.frames_per_buffer() < b.frames_per_buffer();
 }
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_AUDIO_PARAMETERS_H_