chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2670863004: 🏠 Add instrumentation test for Suggestions BottomSheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2670863004: 🏠 Add instrumentation test for Suggestions BottomSheet (Closed)

Patch Set: Wait for recyclerview to stabilise and check view type Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 0e5e08b5dba7c4a0ca902a9b33575853c09a27ec..84d154a3eb40f159099cf933be6c00300844f3ed 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -628,7 +628,7 @@ public void destroy() {

mLogoBridge = null;

}

if (mSnippetsBridge != null) {

- mSnippetsBridge.destroy();

+ mSnippetsBridge.onDestroy();

mSnippetsBridge = null;

}

if (mMostVisitedItemRemovedController != null) {