chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2670863004: 🏠 Add instrumentation test for Suggestions BottomSheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2670863004: 🏠 Add instrumentation test for Suggestions BottomSheet (Closed)

Patch Set: rebase, properly fix test initialisation, address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 587dcf4490e3c9117286b8cdde24716f6186cfa6..6c3869550aaab2e5e023cf620f50b5c7a2b56dc3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -626,7 +626,7 @@ public void destroy() {

mLogoBridge = null;

}

if (mSnippetsBridge != null) {

- mSnippetsBridge.destroy();

+ mSnippetsBridge.onDestroy();

mSnippetsBridge = null;

}

mNewTabPageManager.onDestroy();

« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java » ('j') | no next file with comments »